klemek/forge-steel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 8 Wiki Activity

fix: save_to_file array size bound check

Browse Source
This commit is contained in:
klemek
2026-05-16 17:39:22 +02:00
parent 859dfc4307
commit fd9f94d48a
1 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/state.c
+36
View File
@@ -184,29 +184,65 @@ static void save_to_file(const Context *context, StateConfig state_config,
snprintf(lines.values[lines.length++], STR_LEN, "tempo=%d", snprintf(lines.values[lines.length++], STR_LEN, "tempo=%d",
(unsigned int)context->tempo.tempo); (unsigned int)context->tempo.tempo);
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
snprintf(lines.values[lines.length++], STR_LEN, "page=%d", context->page); snprintf(lines.values[lines.length++], STR_LEN, "page=%d", context->page);
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
snprintf(lines.values[lines.length++], STR_LEN, "selected=%d", snprintf(lines.values[lines.length++], STR_LEN, "selected=%d",
context->selected); context->selected);
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
for (unsigned int i = 0; i < context->state.length; i++) { for (unsigned int i = 0; i < context->state.length; i++) {
snprintf(lines.values[lines.length++], STR_LEN, "seed_%d=%d", i, snprintf(lines.values[lines.length++], STR_LEN, "seed_%d=%d", i,
context->seeds[i]); context->seeds[i]);
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
snprintf(lines.values[lines.length++], STR_LEN, "state_%d=%d", i, snprintf(lines.values[lines.length++], STR_LEN, "state_%d=%d", i,
context->state.values[i]); context->state.values[i]);
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
} }
for (unsigned int i = 0; i < state_config.group_active_counts.length; i++) { for (unsigned int i = 0; i < state_config.group_active_counts.length; i++) {
snprintf(lines.values[lines.length++], STR_LEN, "active_%d=%d", i, snprintf(lines.values[lines.length++], STR_LEN, "active_%d=%d", i,
context->active[i]); context->active[i]);
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
} }
for (unsigned int i = 0; i < state_config.value_count; i++) { for (unsigned int i = 0; i < state_config.value_count; i++) {
snprintf(lines.values[lines.length++], STR_LEN, "value_%d_x=%d", i, snprintf(lines.values[lines.length++], STR_LEN, "value_%d_x=%d", i,
(unsigned int)(context->values[i][0] * MIDI_MAX)); (unsigned int)(context->values[i][0] * MIDI_MAX));
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
snprintf(lines.values[lines.length++], STR_LEN, "value_%d_y=%d", i, snprintf(lines.values[lines.length++], STR_LEN, "value_%d_y=%d", i,
(unsigned int)(context->values[i][1] * MIDI_MAX)); (unsigned int)(context->values[i][1] * MIDI_MAX));
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
snprintf(lines.values[lines.length++], STR_LEN, "value_%d_z=%d", i, snprintf(lines.values[lines.length++], STR_LEN, "value_%d_z=%d", i,
(unsigned int)(context->values[i][2] * MIDI_MAX)); (unsigned int)(context->values[i][2] * MIDI_MAX));
if (lines.length > ARRAY_SIZE) {
log_error("Too many values to save");
return;
}
} }
file_write(state_file, &lines); file_write(state_file, &lines);